-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency vuetify to v3.6.8 #1785
Conversation
5cf2ad1
to
b51b22b
Compare
6226584
to
894c4ae
Compare
894c4ae
to
33bc7a1
Compare
33bc7a1
to
da3c082
Compare
@@ -18,15 +18,11 @@ | |||
import { markRaw } from 'vue' | |||
|
|||
const state = () => ({ | |||
drawer: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1️⃣ For some reason, in Vuetify 3.6, trying to base the drawer visibility state off the vuex store broke resizing the drawer: vuetifyjs/vuetify#19925
See next comment for how I worked around this
/** Global state of navigation drawer visibility */ | ||
const drawer = ref(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2️⃣ This replaces the entry in the vuex store
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
// Prevent Vuetify-provided transitions to ensure responsiveness | ||
el.style.transition = 'none' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this to CSS
/** @type {import('vue').Ref<HTMLElement>} template ref */ | ||
const resizeBar = ref(null) | ||
|
||
when(resizeBar, () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using when
waits until the template ref is available. I think we could use onMounted
instead, but maybe not now that some Vuetify components are using <Suspense>
- see vuetifyjs/vuetify#19736 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appears to work ok. The target region for resizing is very narrow and can be obscured by scroll bars, but this isn't new, opened a separate issue.
/* this is not in our styles/material-dashboard, so we need to force-override */ | ||
-webkit-box-shadow: none !important; | ||
box-shadow: none !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was outdated, wasn't doing anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a visible drop shadow when opening the draw in the workspace view from its collapsed state (i.e. via the toggle button in the top left), but this is fine.
@@ -68,11 +67,14 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
</template> | |||
|
|||
<script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spent a bit of time yesterday trying to make this into <script setup>
but was struggling with these bits
export default {
components: {
Workflows,
'c-header': Header
},
not sure how to rename a component like this in Vue3
mode: import.meta.env.MODE,
version: pkg.version,
don't know where to put these.
Its not necessary anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to specify components in <script setup>
, just import them e.g. import CHeader from '@/components/cylc/Header.vue'
You could do const mode = import.meta.env.MODE
and just use pkg.version
directly in the template
This PR contains the following updates:
3.5.14
->3.6.8
Release Notes
vuetifyjs/vuetify (vuetify)
v3.6.8
Compare Source
v3.6.7
Compare Source
🔧 Bug Fixes
🧪 Labs
v3.6.6
Compare Source
🔧 Bug Fixes
🔄 Reverts
🧪 Labs
v3.6.5
Compare Source
🔧 Bug Fixes
🧪 Labs
v3.6.4
Compare Source
🔧 Bug Fixes
🧪 Labs
v3.6.3
Compare Source
🔄 Reverts
v3.6.2
Compare Source
🔧 Bug Fixes
v3.6.1
Compare Source
See v3.6 Release here
🚀 Features
🔧 Bug Fixes
v3.6.0
Compare Source
v3.6.0 (Nebula)
Welcome to the v3.6.0 release of Vuetify!
💪 Support Vuetify Development
Vuetify is an open source MIT project that has been made possible due to the generous contributions by our sponsors and backers. If you are interested in supporting this project, please consider:
📖 Table of Contents
❗️ Important links
📑 Upgrade guide
🏅 Component promotions
The following components have been promoted to the core framework from labs:
The confirm edit component is a powerful tool that allows you to confirm changes to a field before they are saved. This is especially useful in scenarios where you want to prevent accidental changes to a field.
The empty state component is a simple way to display a message when a list or page is empty. This is useful for informing users that there is no data to display.
The floating action button is a layout aware component that is always visible on the screen. It can also be used inline in conjunction with cards and lists.
The sparkline component is a simple way to display a small chart inline with text. This is useful for displaying trends or other data in a compact format.
The speed dial component is a floating action button that expands into a menu of actions. This is useful for providing quick access to common actions in a compact format.
💯 Release notes
🚀 Features
🔧 Bug Fixes
🧪 Labs
v3.5.18
Compare Source
🔧 Bug Fixes
🧪 Labs
v3.5.17
Compare Source
🔧 Bug Fixes
8083d89
(e569110)🔄 Reverts
🧪 Labs
v3.5.16
Compare Source
🔧 Bug Fixes
🧪 Labs
v3.5.15
Compare Source
🔧 Bug Fixes
🧪 Labs
Configuration
📅 Schedule: Branch creation - "on the 7th day of the month" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.